[mypyc] Fix generation of function wrappers for decorated functions #20584
+15
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For decorated functions, a
FuncDeclis constructed during compilation from anotherFuncDeclbut some attributes are not copied. One of those isis_coroutinewhich is used to determine whether the function will be replaced in the module dictionary by aCPyFunctionobject.The
CPyFunctionobject is needed for introspection functions to work so without it,inspect.iscoroutinefunction(fn)returnsFalsefor decorated async functions. This causes incorrect behavior when theinspectfunction is used in a decorator, for example:In existing test cases this did not come up because the decorators would unconditionally wrap an async function with another async function. Checking
iscoroutinefunctionof the wrapped function would check the wrapper instead, for which aCPyFunctionobject was generated correctly. But during execution ofwrap, the actual wrapped function is checked.