Skip to content

separate the saving of sleep score from the computation of sleep score [WIP] #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
benejoseph wants to merge 1 commit into
base: master
Choose a base branch
from
Open

separate the saving of sleep score from the computation of sleep score [WIP] #1801

benejoseph wants to merge 1 commit into from

Conversation

@benejoseph
Copy link
Contributor

@benejoseph benejoseph commented Oct 14, 2016

  • problem was that sleep score was being saved even though a timeline was discarded
  • the fix is to save the sleep score as the very last thing of retrievetimelinefast
  • also, post-timeline checks shouldn't be in populateTimelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benejoseph