jyfan/account questions id mapping #1691
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Draft of script to fix mapping for survey questions https://github.com/hello/research/pull/17 |
| created, question.category, question.dependencyResponse); | ||
| } | ||
|
|
||
| public static Question withAccountQId(final Question question, final Long accountQuestionId) { |
Contributor
There was a problem hiding this comment.
I'd suggest withAccountQuestionId instead of withAccountQId, we're not saving that many characters and it's more readable.
jykfan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for account_questions_id mapping between tables
account_questionsandresponses.Previously, questionsResource returned account_questions_id=0 always (rather than the row index of the question saved in account_questions) for both onboarding and survey questions.
Not a critical fix.