Skip to content

Conversation

@kingshyg
Copy link
Contributor

  • Moved all sql into individual files named after the table.
  • for sql statements that apply certain updates or inserts, the file will be prefixed with apply_. This is mostly for questions-related tables.
  • In the future, place all ALTER TABLE into the table_name.sql file. Create a new file for new tables.

Tables in common with little data:

  • sleep_feedback (no data)
  • sleep_label (no data)
  • support_topics (1 row)

Tables with schemas but not found in common:

  • pill_provision
  • firmware_updates

Table in common unrelated to suripu:

  • orders_search 😈

@pims
Copy link
Contributor

pims commented Jan 13, 2016

Nice work.

Do you think we should drop all the GRANT… and make chanku-test user granted everything?
Do you think we should have an enum that maps table_name to sql file and move the sql files into core>resources ? That way our integration tests can just refer to the enum value and not care about how the file is named?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants