FDN-4233: small fixes

[arias-m]

Summary by CodeRabbit

• Chores
  • Streamlined CI/CD pipeline configuration for automated deployment versioning
  • Updated build and deployment infrastructure to improve automation efficiency

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@arias-m has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 511ec6a and 38754cc.

📒 Files selected for processing (2)

• deploy/dependency-api/app.yaml (2 hunks)
• deploy/dependency-www/app.yaml (2 hunks)

📝 Walkthrough

Walkthrough

The changes simplify the CI/CD pipeline configuration by removing a variable from the Jenkinsfile and updating version parameters in deployment manifests to be placeholder values that Jenkins will dynamically update at runtime.

Changes

Cohort / File(s)	Summary
Jenkinsfile tagging configuration Jenkinsfile	Removed newTagEveryRunMainBranch variable and updated taggingv2() invocation to call without arguments instead of passing the removed variable
Deployment version placeholders deploy/dependency-api/app.yaml, deploy/dependency-www/app.yaml	Changed Helm parameter deployments.live.version from hardcoded "0.10.33" to "Jenkins_will_update_the_version" in both dependency-api and dependency-www ArgoCD Application manifests

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Configuration value updates with minimal logic implications
• All changes are isolated and straightforward parameter/variable modifications
• No control flow or functional logic changes
• Verify: Confirm that taggingv2() function can be called without arguments as expected in the updated Jenkinsfile

Pre-merge checks

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'small fixes' is vague and generic, failing to describe the specific changes being made in this pull request.	Use a more descriptive title that specifies the main changes, such as 'Remove newTagEveryRunMainBranch variable and update version placeholders' or 'Refactor tagging configuration and deployment versioning'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

deploy/dependency-www/app.yaml (1)

48-49: Verify Jenkins version injection is working for this manifest too.

Same concern as in deploy/dependency-api/app.yaml: the placeholder "Jenkins_will_update_the_version" must be replaced with an actual version before ArgoCD syncs, or deployments will fail.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5c1acf and 511ec6a.

📒 Files selected for processing (3)

• Jenkinsfile (1 hunks)
• deploy/dependency-api/app.yaml (1 hunks)
• deploy/dependency-www/app.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Jenkins

🔇 Additional comments (1)

Jenkinsfile (1)

28-29: Verify taggingv2() behavior without arguments.

The taggingv2() function is now called with no arguments. Ensure that:

1. The function can be safely called without parameters
2. The returned semversion is still correct and valid for subsequent steps
3. The removed newTagEveryRunMainBranch parameter was not critical to the versioning logic

Since taggingv2() is from the shared library @Library('lib-jenkins-pipeline'), please verify:

• The function signature and behavior in the shared library
• Whether removing the parameter changes the version tagging strategy
• That integration tests pass with this change

[flow-tech]

Click here for code coverage report: https://jenkins.flo.pub/job/flowcommerce/job/dependency/job/PR-865/1/scoverage-report/

[flow-tech]

Click here for code coverage report: https://jenkins.flo.pub/job/flowcommerce/job/dependency/job/PR-865/2/scoverage-report/