refactor(aria/accordion): make AccordionGroup and AccordionTrigger members protected for extensibility
#32609
+10
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
AccordionGroupandAccordionTriggerclasses to improve extensibility and internal access for derived classes. Most private members and methods are now marked asprotected, and some initialization logic is moved to a protected property. Additionally, theACCORDION_GROUPtoken is now exported in the public API.Refactoring for Extensibility
privatemembers and methods inAccordionGroupandAccordionTriggertoprotectedto allow access in subclasses. (src/aria/accordion/accordion-group.ts,src/aria/accordion/accordion-trigger.ts) [1] [2] [3]AccordionGroupfrom the constructor to a protected readonly_effectsproperty, making it easier for subclasses to extend or override effect logic. (src/aria/accordion/accordion-group.ts) [1] [2]Public API Update
ACCORDION_GROUPto the public exports inpublic-api.ts, making it available for consumers of the library. (src/aria/accordion/public-api.ts)