fix(eslint-plugin-query): declare typescript as optional peer dependency

[976520]

🎯 Changes

declared typescript as an optional peer dependency to prevent warnings in strict package managers when typescript is not installed.

(resloved #9846)

✅ Checklist

• I have followed the steps in the Contributing guide.
• I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

• This change affects published code, and I have generated a changeset.
• This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

• Chores
  • Declared TypeScript as a peer dependency (>=5.0.0 <6.0.0) for the eslint-plugin-query package.
  • Marked the TypeScript peer dependency as optional in the package metadata so projects without TypeScript are unaffected.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[changeset-bot]

⚠️ No Changeset found

Latest commit: c1a8e4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The eslint-plugin-query package.json adds typescript (>=5.0.0 <6.0.0) to peerDependencies and marks it optional via peerDependenciesMeta; eslint remains declared as a peer dependency.

Changes

Cohort / File(s)	Summary
Peer dependency declarations packages/eslint-plugin-query/package.json	Add typescript: ">=5.0.0 <6.0.0" to peerDependencies and set peerDependenciesMeta entry for typescript to { "optional": true }

Sequence Diagram(s)

(silently skipped — changes are package metadata only)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• fix(eslint-plugin): avoid imports from typescript #9759 — Removes runtime imports of typescript in eslint rules and shifts to type-only usage, closely related to declaring TypeScript as an optional peer dependency.

Suggested reviewers

• lachlancollins

Poem

🐰 A tiny hop for package.json today,
TypeScript waits optional along the way,
A gentle flag, no heavy bind,
Use it if you wish — otherwise, rewind. 🥕🐇

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: declaring typescript as an optional peer dependency in the eslint-plugin-query package.
Description check	✅ Passed	The description follows the template with all required sections completed: Changes section explains the motivation, checklist items are checked/marked appropriately, and Release Impact reflects the dev-only nature.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14c0ec8 and ef7ff82.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

• packages/eslint-plugin-query/package.json

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.

Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.

📚 Learning: 2025-09-02T17:57:33.184Z

Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.

Applied to files:

• packages/eslint-plugin-query/package.json

📚 Learning: 2025-08-19T03:18:18.303Z

Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.

Applied to files:

• packages/eslint-plugin-query/package.json

[nx-cloud]

View your CI Pipeline Execution ↗ for commit e0c671d

---

☁️ Nx Cloud last updated this comment at 2025-12-31 09:38:27 UTC

[TkDodo]

you need to update the lockfile!

[976520]

@TkDodo

good catch, thanks — and happy new year!

c1a8e4d