Instance log and diagnostics files not written to configured location #5248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During smoketesting of v6.9.0, we noticed that after deployed on a Windows VM, the logs were not written to the expected location.
Symptoms
The configured log path is not used, and logs are instead written to the installation directory of the instance
Who's affected
Users hosting ServiceControl, Audit, or Monitoring as a Windows service
Root cause
All instances invoke
ExeConfiguration.PopulateAppSettingsbut that happens AFTER logging is initialized. This causes the internalLogPathsetting to not be initialized correctly.Confirmed workarounds
None
Resolution
Invoking
ExeConfiguration.PopulateAppSettingsbefore logging it initialized.