[MySQL] az mysql flexible-server backup delete: Support deletion of on-demand backup
#32547
+79,951
−52,943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honghr
requested review from
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| mysql flexible-server backup delete | cmd mysql flexible-server backup delete added |
||
| mysql flexible-server backup show | cmd mysql flexible-server backup show update parameter backup_name: removed property id_part=child_name_1 |
||
| mysql flexible-server backup show | cmd mysql flexible-server backup show update parameter server_name: removed property id_part=name |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
yonzhan and
zhoxing-ms
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for deleting on-demand backups through the Azure CLI for MySQL Flexible Server and deprecates the --storage-redundancy parameter across relevant commands. The implementation updates the underlying SDK package and removes the deprecated parameter from test cases.
Key Changes
- Added
az mysql flexible-server backup deletecommand to enable deletion of on-demand backups - Deprecated the
--storage-redundancyparameter across create, restore, geo-restore, and replica create commands - Updated
azure-mgmt-mysqlflexibleserverspackage from version1.0.0b3to1.1.0b2
Reviewed changes
Copilot reviewed 9 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
setup.py |
Updated azure-mgmt-mysqlflexibleservers dependency to version 1.1.0b2 |
requirements.py3.windows.txt |
Updated azure-mgmt-mysqlflexibleservers dependency to version 1.1.0b2 |
requirements.py3.Linux.txt |
Updated azure-mgmt-mysqlflexibleservers dependency to version 1.1.0b2 |
requirements.py3.Darwin.txt |
Updated azure-mgmt-mysqlflexibleservers dependency to version 1.1.0b2 |
test_mysql_scenario.py |
Removed storage-redundancy parameter usage from tests; updated maintenance test date to future date; skipped export test |
test_mysql_flexible_server_maintenance_mgmt.yaml |
Updated test recording with new maintenance reschedule date and API version |
commands.py |
Added backup delete command registration |
_params.py |
Added parameter definitions for backup delete; deprecated storage-redundancy parameter; updated backup show parameter definitions for consistency |
_help.py |
Added help documentation for backup delete command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with self.command_group('mysql flexible-server backup', mysql_flexible_long_running_backup_sdk, | ||
| client_factory=cf_mysql_flexible_backup) as g: | ||
| g.command('create', 'begin_create') | ||
| g.command('delete', 'begin_delete') |
There was a problem hiding this comment.
The newly added backup delete command lacks test coverage. The existing test file test_mysql_scenario.py has a test for backup create in the _test_backups_mgmt method, but there is no corresponding test for the delete functionality. Consider adding test coverage for this new command to ensure it functions correctly.
evelyn-ys
reviewed
Dec 17, 2025
evelyn-ys
previously approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server backup delete
az mysql flexible-server create --storage-redundancy
az mysql flexible-server restore --storage-redundancy
az mysql flexible-server geo-restore --storage-redundancy
az mysql flexible-server replica create --storage-redundancy
Description
Need the ability to support deletion of on-demand backup through CLI
Add deprecation warning for --storage-redundancy
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.