Skip to content

TAS NodeHotSwap: make sure QueueSecondPassIfNeeded removes workload from second-queue pass if no longer needed #8357

@mimowo

Description

@mimowo

What would you like to be cleaned:

Make sure workload controller calling QueueSecondPassIfNeeded would remove the workload from second pass queue if no longer needed there.

The scenario:

  1. node failure controller adds the unhealthyNodes to the workload
  2. workload controller adds the workload to QueueSecondPassIfNeeded
  3. node failure controller removes the node from unhealtyNodes becuase the node is now healthy
    Issue: workload controller does not remove the workload from QueueSecondPassIfNeeded

Why is this needed:

To avoid potential race condition bugs, and make the interaction between controllers easier.

Metadata

Metadata

Assignees

Labels

kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions