Skip to content

Conversation

@Evlers
Copy link
Contributor

@Evlers Evlers commented Jan 14, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the wifi-host-driver package to support version 1.3.1, adding new configuration options and hardware support while removing the deprecated v1.0.0 version.

Changes:

  • Added v1.3.1 to package.json and removed deprecated v1.0.0
  • Reorganized Kconfig with new menu structure for better configuration organization
  • Added support for WiFi 6 chips (CYW55500, CYW55572) and new porting options
  • Enhanced configuration with country code settings, NVRAM paths, and improved logging options

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
iot/wifi-host-driver/package.json Added v1.3.1 package entry and removed v1.0.0
iot/wifi-host-driver/Kconfig Extensive reorganization with new v1.3.1 features including WiFi 6 chip support, country code configuration, NVRAM settings, porting options, and enhanced logging configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

default "PA.1"
endif
config CYBSP_OOB_INTR_PRIORITY
int "Set the interrput priority for HOST_WAKE_IRQ pin"
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'interrput' to 'interrupt'.

Suggested change
int "Set the interrput priority for HOST_WAKE_IRQ pin"
int "Set the interrupt priority for HOST_WAKE_IRQ pin"

Copilot uses AI. Check for mistakes.
int "Set the WiFi_REG ON pin number"
default -1
config WHD_LOG_LEVEL_NONE
select WHD_PRINT_DISABLE
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation: the 'select' directive should be indented at the same level as the 'bool' directive. Both should be indented equally under the config option.

Suggested change
select WHD_PRINT_DISABLE
select WHD_PRINT_DISABLE

Copilot uses AI. Check for mistakes.
@Rbb666 Rbb666 merged commit 51563bc into RT-Thread:master Jan 15, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants